[Breaking] listen_address renamed/remapped in config #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allada
commented
Dec 12, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 14 files reviewed, all discussions resolved (waiting on @adam-singer)
allada
commented
Dec 12, 2023
There was a problem hiding this comment.
fyi: @chrisstaite-menlo
Reviewable status: 0 of 14 files reviewed, all discussions resolved (waiting on @adam-singer)
adam-singer
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Nice, naming choice feels more natural !
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @allada)
Moved `listen_address` to `listener.http.socket_address` mapping. This future proofs our config a bit more so we can add other kinds of listeners that are not http based (like unix sockets). In doing this we also moved the http(s)/http2 related fields into the same struct.
allada
force-pushed
the
move-service-socket-config
branch
from
263e579
to
f760d9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
listen_addresstolistener.http.socket_addressmapping.This future proofs our config a bit more so we can add other kinds of listeners that are not http based (like unix sockets).
In doing this we also moved the http(s)/http2 related fields into the same struct.
This change is